Skip to content

Update error in case fypp preprocessor is not found #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2021
Merged

Update error in case fypp preprocessor is not found #578

merged 1 commit into from
Nov 25, 2021

Conversation

awvwgk
Copy link
Member

@awvwgk awvwgk commented Nov 25, 2021

Provide a better error message in case the fypp preprocessor cannot be found by CMake. Point the user to the installation instructions at https://fypp.readthedocs.io/en/stable/fypp.html#installing

@awvwgk awvwgk added reviewers needed This patch requires extra eyes build: cmake Issue with stdlib's CMake build files labels Nov 25, 2021
jvdp1
jvdp1 approved these changes Nov 25, 2021
View reviewed changes
Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@ivan-pi
Copy link
Member

ivan-pi commented Nov 25, 2021

Since it's a small change I'll just go ahead and merge. Thanks!

@ivan-pi ivan-pi merged commit 57c41f9 into fortran-lang:master Nov 25, 2021
@awvwgk awvwgk deleted the fypp-error branch November 25, 2021 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvdp1 jvdp1 jvdp1 approved these changes

@ivan-pi ivan-pi ivan-pi approved these changes

Assignees
No one assigned
Labels
build: cmake Issue with stdlib's CMake build files reviewers needed This patch requires extra eyes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@awvwgk @ivan-pi @jvdp1